You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I added 2 new tests to test fragmentation of secio/noise with big packets and on one of the CI providers (and 32bits builds only afaik) they caused the big monolitic testnative to fail even before the new tests were even called.
I know @dryajov also had issues in the past with tests order etc.
The reality is that our tests are ok but not perfect. We barely release all the resources and close what needs to be closed. There are lingering Futures and what not.
So my question is why not just pay the price of a bit slower builds (should not be too slow if we share nimcache no?) and split the monolitic testnative in many other tests?
Why this was not done from the start btw? slow build times?
Why this was not done from the start btw? slow build times?
because otherwise, there's no easy way to run all tests and it seemed wrong to optimize test running for hiding resource leaks.
Also, the problem will not be limited to different test modules - also individual tests that run after one another will have this issue albeit at a smaller scale.
I added 2 new tests to test fragmentation of secio/noise with big packets and on one of the CI providers (and 32bits builds only afaik) they caused the big monolitic
testnative
to fail even before the new tests were even called.I know @dryajov also had issues in the past with tests order etc.
The reality is that our tests are ok but not perfect. We barely release all the resources and close what needs to be closed. There are lingering
Futures
and what not.So my question is why not just pay the price of a bit slower builds (should not be too slow if we share nimcache no?) and split the monolitic
testnative
in many other tests?Why this was not done from the start btw? slow build times?
Related to #75
P.S. until this situation is handled I'm putting on hold adding
https://github.com/sinkingsugar/nim-libp2p-rs-interop
The text was updated successfully, but these errors were encountered: