Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up testnative #121

Closed
sinkingsugar opened this issue Mar 27, 2020 · 3 comments
Closed

Split up testnative #121

sinkingsugar opened this issue Mar 27, 2020 · 3 comments
Labels
discuss enhancement New feature or request

Comments

@sinkingsugar
Copy link
Contributor

I added 2 new tests to test fragmentation of secio/noise with big packets and on one of the CI providers (and 32bits builds only afaik) they caused the big monolitic testnative to fail even before the new tests were even called.
I know @dryajov also had issues in the past with tests order etc.

The reality is that our tests are ok but not perfect. We barely release all the resources and close what needs to be closed. There are lingering Futures and what not.

So my question is why not just pay the price of a bit slower builds (should not be too slow if we share nimcache no?) and split the monolitic testnative in many other tests?
Why this was not done from the start btw? slow build times?

Related to #75

P.S. until this situation is handled I'm putting on hold adding
https://github.com/sinkingsugar/nim-libp2p-rs-interop

@sinkingsugar sinkingsugar added enhancement New feature or request discuss labels Mar 27, 2020
@sinkingsugar sinkingsugar changed the title Split up tests Split up testnative Mar 27, 2020
@arnetheduck
Copy link
Contributor

Why this was not done from the start btw? slow build times?

because otherwise, there's no easy way to run all tests and it seemed wrong to optimize test running for hiding resource leaks.

Also, the problem will not be limited to different test modules - also individual tests that run after one another will have this issue albeit at a smaller scale.

@dryajov
Copy link
Contributor

dryajov commented Mar 27, 2020

Can you describe what is failing for you now? Can you isolate the tests that's failing as well?

@sinkingsugar
Copy link
Contributor Author

sinkingsugar commented Mar 27, 2020

Well for now it's a "operation not on a socket" error from chronos popping.
https://ci.appveyor.com/project/nimbus/nim-libp2p/builds/31759110/job/ixrkjc2jna7rn9c8
But it's not systematic at all.
One of the issues is that we barely close any resource and we also do not wait the release of many of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants