Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent concurrent IWANT of the same message #868

Closed
arnetheduck opened this issue Feb 22, 2023 · 0 comments · Fixed by #943
Closed

Prevent concurrent IWANT of the same message #868

arnetheduck opened this issue Feb 22, 2023 · 0 comments · Fixed by #943
Labels
gossipsub performance performance and resource ussage

Comments

@arnetheduck
Copy link
Contributor

arnetheduck commented Feb 22, 2023 •
edited by Menduist
Loading

If two peers send us the same IHAVE, we should not concurrently request the same message from both

EDIT from @Menduist:
We should track outgoing IWANTs, and if a peer doesn't sends us the message in a timely manner, a behavior penalty should be applied.
This timeout should be configurable, and default to 3 heartbeats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gossipsub performance performance and resource ussage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent concurrent IWANT of the same message vacp2p/nim-libp2p
1 participant
@arnetheduck