Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Get store protocol to draft state #200

Closed
oskarth opened this issue Oct 2, 2020 · 1 comment
Closed

Get store protocol to draft state #200

oskarth opened this issue Oct 2, 2020 · 1 comment
Assignees

Comments

@oskarth
Copy link
Contributor

oskarth commented Oct 2, 2020

Problem

For Dingpu we want to store protocol to correspond to their implementation, i.e. be in draft mode.

Acceptance criteria

  1. Cluster node needs to be updated, and tested (e.g. with chat2 or storeclient script), for this spec to be considered in draft: Deploy and ensure cluster node support store and filter server role waku-org/nwaku#198

  2. Spec should correspond to what is in nim-waku implementation.

  3. Spec fixes. See below.

Spec fixes

Currently there are a bunch of TODOs for spec:

  • WakuMessage should be updated and linked
  • Bump to draft and beta1
  • Add release date
  • Reference updated in main Waku spec

This allows the node handler to determine how to handle a message as the Waku Filter protocol is not a request response based protocol but instead a push based system.

This doesn't much sense to me. Why is store protocol talking about filter protocol?

Anything else that is obviously missing.

Notes

A corresponding issue should be created for the filter protocol.

@oskarth oskarth changed the title Get store protocol to corresponding draft state Get store protocol to draft state Oct 2, 2020
@decanus decanus moved this from New to In progress in Vac PM Board (Legacy) Oct 5, 2020
@decanus decanus self-assigned this Oct 5, 2020
@decanus decanus closed this as completed Oct 6, 2020
Vac PM Board (Legacy) automation moved this from In progress to Done Oct 6, 2020
@oskarth
Copy link
Contributor Author

oskarth commented Oct 7, 2020

Cluster node needs to be updated, and tested (e.g. with chat2 or storeclient script), for this spec to be considered in draft: waku-org/nwaku#198

@decanus this was part of acceptance criteria, can you confirm the cluster node is updated and works?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants