New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Waku existing light node behavior #29
Comments
@decanus do you want to take a look at this one? |
So I added light node description in specs/light-node. This documents both the behaviour in geth and nimbus which are identical. Its rather simple, one thing left to look at is the handshake. Would also make sense to discuss with core to see which functionality is used in the app. cc @kdeme |
@decanus Seems like this is modifying the existing waku spec, can we add it to existing PR? It'll get messy quickly if we have too many branches IMO. |
@oskarth I can just merge it yea. |
Important to note that status clients run in light mode. |
Current docs https://github.com/status-im/specs/blob/master/status-client-spec.md#mobile-nodes Note inconsistent terms and different MUST/MAY usage cc @adambabik |
@decanus what's state of this? |
Although compact, seems good imo: https://github.com/vacp2p/specs/blob/master/waku.md#light-node |
Problem
Waku adds a light node status that isn't documented in the existing Whisper docs. This makes it hard for clients to implement and reason about wrt connectivity, privacy guarantees and perf.
Acceptance criteria
Details
See https://github.com/status-im/whisper/blob/8be20fd33d56bce7a886a93101984d5a1fe101af/whisperv6/peer.go#L80 and https://github.com/status-im/whisper/blob/8be20fd33d56bce7a886a93101984d5a1fe101af/whisperv6/api.go#L194
And https://github.com/status-im/nim-eth/blob/c64a370fe7a49d8d8d287d043870ecec1251676e/eth/p2p/rlpx_protocols/whisper_protocol.nim#L780
Possible Solutions
Look at details and amend EIP627 in https://github.com/vacp2p/specs/pull/28/files
Notes
Check with @adamb and @kdeme if there are any gotchas here
The text was updated successfully, but these errors were encountered: