Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Waku existing light node behavior #29

Closed
3 tasks done
oskarth opened this issue Nov 15, 2019 · 8 comments
Closed
3 tasks done

Document Waku existing light node behavior #29

oskarth opened this issue Nov 15, 2019 · 8 comments
Assignees

Comments

@oskarth
Copy link
Member

oskarth commented Nov 15, 2019

Problem

Waku adds a light node status that isn't documented in the existing Whisper docs. This makes it hard for clients to implement and reason about wrt connectivity, privacy guarantees and perf.

Acceptance criteria

Details

See https://github.com/status-im/whisper/blob/8be20fd33d56bce7a886a93101984d5a1fe101af/whisperv6/peer.go#L80 and https://github.com/status-im/whisper/blob/8be20fd33d56bce7a886a93101984d5a1fe101af/whisperv6/api.go#L194

And https://github.com/status-im/nim-eth/blob/c64a370fe7a49d8d8d287d043870ecec1251676e/eth/p2p/rlpx_protocols/whisper_protocol.nim#L780

Possible Solutions

Look at details and amend EIP627 in https://github.com/vacp2p/specs/pull/28/files

Notes

Check with @adamb and @kdeme if there are any gotchas here

@oskarth
Copy link
Member Author

oskarth commented Nov 15, 2019

@decanus do you want to take a look at this one?

@decanus
Copy link
Contributor

decanus commented Nov 15, 2019

So I added light node description in specs/light-node. This documents both the behaviour in geth and nimbus which are identical. Its rather simple, one thing left to look at is the handshake. Would also make sense to discuss with core to see which functionality is used in the app.

cc @kdeme

@oskarth
Copy link
Member Author

oskarth commented Nov 18, 2019

@decanus Seems like this is modifying the existing waku spec, can we add it to existing PR? It'll get messy quickly if we have too many branches IMO.

@decanus
Copy link
Contributor

decanus commented Nov 18, 2019

@oskarth I can just merge it yea.

@decanus
Copy link
Contributor

decanus commented Nov 20, 2019

Important to note that status clients run in light mode.

@oskarth
Copy link
Member Author

oskarth commented Nov 20, 2019

Current docs https://github.com/status-im/specs/blob/master/status-client-spec.md#mobile-nodes

Note inconsistent terms and different MUST/MAY usage cc @adambabik

@oskarth
Copy link
Member Author

oskarth commented Dec 2, 2019

@decanus what's state of this?

@decanus
Copy link
Contributor

decanus commented Dec 2, 2019

Although compact, seems good imo: https://github.com/vacp2p/specs/blob/master/waku.md#light-node

@decanus decanus closed this as completed Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants