Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 0.1.0 remote log initial spec #16

Merged
merged 10 commits into from Oct 3, 2019
Merged

Add 0.1.0 remote log initial spec #16

merged 10 commits into from Oct 3, 2019

Conversation

oskarth
Copy link
Member

@oskarth oskarth commented Sep 30, 2019

Initial draft

remote-log.md Show resolved Hide resolved
remote-log.md Show resolved Hide resolved
remote-log.md Show resolved Hide resolved
remote-log.md Outdated Show resolved Hide resolved
@oskarth
Copy link
Member Author

oskarth commented Oct 1, 2019

@decanus fixed

@oskarth oskarth requested a review from cammellos October 1, 2019 03:35
remote-log.md Outdated Show resolved Hide resolved
remote-log.md Outdated Show resolved Hide resolved
remote-log.md Outdated Show resolved Hide resolved
@oskarth
Copy link
Member Author

oskarth commented Oct 2, 2019

@decanus fixed tweaks, ptal

Copy link
Contributor

@decanus decanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to document the flow. Underneath the diagram

@decanus
Copy link
Contributor

decanus commented Oct 2, 2019

@oskarth So as discussed for this to be more useful with the metadata field. It makes sense to explicitly list what sequence a message is <local hash, remote hash, data, seqid> this way I can easily sync a messages prior or after a specific number. To enable this to be dynamic it might make sense to add page info so that I am aware which page I can find seqid on.

@decanus
Copy link
Contributor

decanus commented Oct 3, 2019

Also @oskarth add the remotelog to the readme.

@oskarth
Copy link
Member Author

oskarth commented Oct 3, 2019

@decanus do you mind if we merge this as draft? want to think a bit more about the seqid idea before just adding more stuff

@decanus
Copy link
Contributor

decanus commented Oct 3, 2019

@oskarth do it

@oskarth oskarth merged commit d218ca6 into master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants