Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 0.1.0 remote log initial spec #16

Merged
merged 10 commits into from Oct 3, 2019

Conversation

@oskarth
Copy link
Member

commented Sep 30, 2019

Initial draft

@oskarth oskarth requested a review from decanus Sep 30, 2019
remote-log.md Show resolved Hide resolved
remote-log.md Show resolved Hide resolved
remote-log.md Show resolved Hide resolved
remote-log.md Outdated Show resolved Hide resolved
@oskarth

This comment has been minimized.

Copy link
Member Author

commented Oct 1, 2019

@decanus fixed

@oskarth oskarth requested a review from cammellos Oct 1, 2019
oskarth added 2 commits Oct 1, 2019
remote-log.md Outdated Show resolved Hide resolved
remote-log.md Outdated Show resolved Hide resolved
remote-log.md Outdated Show resolved Hide resolved
@oskarth oskarth requested a review from arnetheduck Oct 2, 2019
@oskarth

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

@decanus fixed tweaks, ptal

Copy link
Member

left a comment

It might make sense to document the flow. Underneath the diagram

@decanus

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

@oskarth So as discussed for this to be more useful with the metadata field. It makes sense to explicitly list what sequence a message is <local hash, remote hash, data, seqid> this way I can easily sync a messages prior or after a specific number. To enable this to be dynamic it might make sense to add page info so that I am aware which page I can find seqid on.

@decanus

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Also @oskarth add the remotelog to the readme.

@oskarth

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

@decanus do you mind if we merge this as draft? want to think a bit more about the seqid idea before just adding more stuff

oskarth added 3 commits Oct 3, 2019
@decanus

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

@oskarth do it

@decanus
decanus approved these changes Oct 3, 2019
@oskarth oskarth merged commit d218ca6 into master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.