Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Make Waku Web Client relay spec compliant #1

Closed
oskarth opened this issue Sep 21, 2020 · 5 comments
Closed

Make Waku Web Client relay spec compliant #1

oskarth opened this issue Sep 21, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@oskarth
Copy link
Contributor

oskarth commented Sep 21, 2020

Problem

Currently browser/node impl are not spec compliant. Client should conform to spec: https://specs.vac.dev/specs/waku/v2/waku-v2.html

Details

  1. Most immediately, messages should be wrapped in WakuMessage.
  2. Currently there's a hack to overwrite GossipSub. This should inherit and be relay protocol.
  3. There is probably something related to signing policy etc

Acceptance

Implementation is according to spec, at a minimum wrap with WakuMessage protobuf.

Further enhancement

Implement store and filter protocol.

@decanus decanus moved this from New to Icebox in Vac PM Board (Legacy) Sep 22, 2020
@decanus decanus moved this from Icebox to Next in Vac PM Board (Legacy) Sep 22, 2020
@oskarth
Copy link
Contributor Author

oskarth commented Oct 5, 2020

FYI: Barry @bgits is working on this, can't assign on GH though (pending invitation).

@oskarth oskarth added the bug Something isn't working label Oct 5, 2020
@oskarth
Copy link
Contributor Author

oskarth commented Oct 15, 2020

Not sure if any progress is happening here. I started here https://github.com/vacp2p/waku-web-chat/blob/master/nodejs/src/chat.js#L75

@oskarth oskarth self-assigned this Oct 15, 2020
@oskarth oskarth moved this from Next to In progress in Vac PM Board (Legacy) Oct 15, 2020
@oskarth
Copy link
Contributor Author

oskarth commented Oct 15, 2020

There's quite a bunch of dimensions here:

  • (subscribe, publish)
  • (nodejs, browser)
  • nim-waku interop both ways
  • wrapping request protocol on both waku web and chat2 side

So might have to cut this issue up a bit more / limit capabilities of this example.

For now it is under a flag.

@oskarth
Copy link
Contributor Author

oskarth commented Oct 16, 2020

Follow up issues:

Might create more. I believe after these two are closed the minimal path for original issue is done, though it could definitely be enhanced.

@oskarth
Copy link
Contributor Author

oskarth commented Oct 19, 2020

Minimal steps done. Leaving enhancements for later.

@oskarth oskarth closed this as completed Oct 19, 2020
Vac PM Board (Legacy) automation moved this from In progress to Done Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

1 participant