Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semaphore: module refactoring #78

Closed
s1fr0 opened this issue Nov 22, 2022 · 0 comments
Closed

Semaphore: module refactoring #78

s1fr0 opened this issue Nov 22, 2022 · 0 comments
Labels
track:zerokit Zerokit track (Applied ZK/Explorations)

Comments

@s1fr0
Copy link
Contributor

s1fr0 commented Nov 22, 2022

Problem

Currently, zerokit semaphore module implements wrappers around API exposed by semaphore-rs, a submodule of the semaphore crate.

This doesn't allow the same flexibility and easy features extension currently allowed e.g., by the zerokit RLN module.

Furthermore, using submodules makes hard to deal with any eventually breaking change introduced by submodule's dependencies, as happened in #79. This results in a failing zerokit compilation and leaves few possibilities to solve such issue quickly without relying on forks and/or dependencies' developers response.

Acceptance criteria

  • Refactor semaphore module similarly as the RLN module (public API, FFI, zk resources, MT implementation, etc.)
@s1fr0 s1fr0 added the track:zerokit Zerokit track (Applied ZK/Explorations) label Nov 22, 2022
@s1fr0 s1fr0 mentioned this issue Jan 9, 2023
25 tasks
@rymnc rymnc mentioned this issue May 2, 2023
5 tasks
@rymnc rymnc added this to the Release v0.3.0 milestone May 2, 2023
@rymnc rymnc removed this from the Release v0.3.0 milestone Jul 31, 2023
@rymnc rymnc closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
track:zerokit Zerokit track (Applied ZK/Explorations)
Projects
Status: Done
Development

No branches or pull requests

2 participants