Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept plain strings as style #35

Closed
fregante opened this issue Mar 25, 2019 · 1 comment
Closed

Accept plain strings as style #35

fregante opened this issue Mar 25, 2019 · 1 comment
Labels
enhancement

Comments

@fregante
Copy link
Collaborator

fregante commented Mar 25, 2019 •
edited
Loading

Supported

<div style={{display: 'none'}}/>

Unsupported

<div style="display: none"/>

This isn't supported by JSX TypeScript types so they should be extended as well.
@fregante fregante mentioned this issue Apr 1, 2019
Merged
@fregante
Copy link
Collaborator Author

fregante commented Sep 7, 2020

While object props look awkward, they're type-checked, so they're preferred to plain strings. Let's not support this

@fregante fregante closed this as completed Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fregante