Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftyJSON depency #51

Closed
d3pwnd opened this issue Sep 22, 2016 · 7 comments
Closed

SwiftyJSON depency #51

d3pwnd opened this issue Sep 22, 2016 · 7 comments

Comments

@d3pwnd
Copy link

d3pwnd commented Sep 22, 2016

SwiftyJSON decency is not pointing to any specific release, though due to the new SwiftyJSON Release (Support for Swift 3.0) my project (Swift2.2) can't use Fakery anymore.

Should be fixed with replacing s.dependency 'SwiftyJSON', '< 3.0.0' to pod-spec.

@fuxx
Copy link

fuxx commented Sep 23, 2016

Same for me. I cant upgrade to Swift 3.0 yet. A pod update would be great. Thanks!

@vadymmarkov
Copy link
Owner

vadymmarkov commented Sep 23, 2016

@d3pwnd @fuxx I'm planning to do Swift 3 migration during the next week, so it will be fixed there.

@fuxx
Copy link

fuxx commented Sep 23, 2016

Hi @vadymmarkov thanks for the quick reply. We didnt meant Swift 3 :)
We have to stick to Swift 2.2 for some weeks as Facebook and some other dependencies are not yet ready for Swift 3. Unfortunately you did not specify a version for SwiftyJSON in your dependencies.

Because of that the latest version is being used which is already lifted to Swift 3. The problem now is, that we need a pod update from you were the SwiftyJSON version is hardwired to Swift 2.2.

Only other option right now is to mirror the project to a private pod repo and maintain it on our own, but anyway for the future a hardwired version number of SwiftyJSON would be good as on future upgrades like Swift 4 we would have the same problems again.

@vadymmarkov
Copy link
Owner

@fuxx @d3pwnd I've made 1.3.2 release with specified SwiftyJSON version is Podspec 😉

@fuxx
Copy link

fuxx commented Sep 26, 2016

Great, works flawless. Thanks for the effort!

@d3pwnd
Copy link
Author

d3pwnd commented Sep 26, 2016

Thx for the quick response, i appreciate is.

@vadymmarkov
Copy link
Owner

I'm closing this one. Also Fakery doesn't have any dependencies anymore from the last release 1.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants