Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple styles #12

Merged
merged 4 commits into from Apr 9, 2017
Merged

Conversation

yonaskolb
Copy link
Contributor

This allows you to register multiple styles for the same strings. This is useful when grouping different styles ie (all these get shadows), and then setting other properties in other closures.

This pull request also allows you to clear styles, and fixes some swift warnings

@vadymmarkov
Copy link
Owner

@yonaskolb Looks great! Could you please add some tests?

@yonaskolb
Copy link
Contributor Author

Added tests.
Technically this is a breaking change as someone who is relying on the fact that re-registering a style will overwrite it, will find different behaviour here

@vadymmarkov vadymmarkov merged commit 6517886 into vadymmarkov:master Apr 9, 2017
@vadymmarkov
Copy link
Owner

Thanks @yonaskolb. I'll release a new version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants