Remove validation of 204 responses in .validate() #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the default
.validate()
fails when receiving a HTTP 204 NO CONTENT response trough Express, as Express strips away those fields when not needed.If the maintainers agree, I'd like to remove 204 from the standard
.validate()
method in ResponseValidation.swift.Edit:
A more detailed explanation of why it doesn't work: If you set
application/json
asAccept
and receive a 204, Express strips theContent-Type
field making NSURLRequest do its best to guess theContent-Type
itself, and as Express doeschunk = ''
on a 204, it assumes itstext/plain
. That obviously fails content type validation.