Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @discardableResult to promises that run in different queues #23

Merged

Conversation

zenangst
Copy link
Contributor

This fixes warnings that occur when you use promises with dispatch queues. The fix is to add @discardableResult so that you don't have to keep a reference of the promise result.

This fixes warnings that occur when you use promises with dispatch
queues. The fix is to add @discardableResult so that you don't have to
keep a reference of the promise result.
@zenangst
Copy link
Contributor Author

Look at me #contributing!

303acd1 jpg

@zenangst
Copy link
Contributor Author

Oh Travis...

Copy link
Owner

@vadymmarkov vadymmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zenangst 🚀

@vadymmarkov vadymmarkov merged commit 767dd02 into vadymmarkov:master Aug 27, 2017
@zenangst zenangst deleted the fix/warnings-when-dispatching branch August 27, 2017 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants