Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you have more than a few tabs, at narrow screen sizes, the tabs bust the UI #67

Closed
johnwbaxter opened this issue Oct 24, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@johnwbaxter
Copy link

johnwbaxter commented Oct 24, 2023

When you bring the width of the editor down (for example when using live preview on a smaller screen), if you have a few tabs, it all overlaps each other. See screenshot below:

image

It gets worse when you get even narrower, with this many tabs!

image

It's far from ideal, but you can get round this if you inject you tabs a smidge further up the dom and then someone like me with this very specific issue can add css cp that changes the tabs position from absolute to relative...but I'm sure there is a better solution!

image

@mmikkel
Copy link
Member

mmikkel commented Oct 26, 2023

Thanks for reporting that, @johnwbaxter. I'll have a closer look at it as soon as I have the time.

@johnwbaxter
Copy link
Author

Cool, cheers @mmikkel !!

@mmikkel mmikkel added the enhancement New feature or request label Nov 10, 2023
@mmikkel
Copy link
Member

mmikkel commented Nov 10, 2023

Update: I've taken a closer look at this; there's no quick fix and since there are multiple problems with the current implementation of block tabs I've decided to rework how they are implemented from scratch, to increase accessibility overall. I can't give an ETA for that update but will make sure to accommodate the use case where the total width of the tabs is wider than the available horizontal space.

@mmikkel
Copy link
Member

mmikkel commented Nov 10, 2023

I mean, you presented a quick fix. But that would only kick the bucket a bit further down the road; I think a proper solution would either collapse the tabs into a disclosure menu, or make them horizontally scrollable, when the available horizontal space is too small.

I'm leaning towards a disclosure menu because that would probably be the most consistent in terms of the overall Craft CP UI, but I'm very open for opinions as to which of those options would feel like the better (and most accessible) UX.

@johnwbaxter
Copy link
Author

@mmikkel Hey man, any news on this one? Could we sponsor this feature in some way if that helps?

@mmikkel
Copy link
Member

mmikkel commented Jan 14, 2024

Hi @johnwbaxter, I haven't had the time to look into this one yet – will update this issue when there's something to report. And thank you for the offer; I'm not really interested in that but I'll try my best to make this a priority, as soon as I have some available time.

@johnwbaxter
Copy link
Author

Hey @mmikkel, ok no worries, thank you :)

@mmikkel
Copy link
Member

mmikkel commented May 30, 2024

Considering MatrixMate is retired for Craft 5, I've decided to not put any significant time into the plugin at this point beyond making sure things "mostly work" for Craft 4 until its EOL. Sorry!

@mmikkel mmikkel closed this as completed May 30, 2024
@johnwbaxter
Copy link
Author

@mmikkel Ok, understood, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants