Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selection is slow, is there a way to improve it? #10

Closed
bombrun opened this issue Nov 3, 2016 · 3 comments
Closed

selection is slow, is there a way to improve it? #10

bombrun opened this issue Nov 3, 2016 · 3 comments

Comments

@bombrun
Copy link

bombrun commented Nov 3, 2016

Using selection slow down the computation of a statistics. Using clever binning is much more efficient. Isn't it a way to improve how the selection is implemented?

@maartenbreddels
Copy link
Member

Ok, I thought a bit about this, and it should improve soon since in the plotting, multiple selections are done in parallel. That means that it scales linearly in time with the number of selections, while actually it can be done in one go, so if I fix this it will go faster.

@maartenbreddels
Copy link
Member

Apart from evaluating the selection, when a selection is used, the data is copied, instead, we could pass the mask array to the statisticNd algo (which does the binning), so that no copy of the data is made, this could speed up using selections alot I think.

@maartenbreddels
Copy link
Member

Cleaning up issues, this is changed in master, performance is much better, feel free to reopen if still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants