Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to configure a domain name per network #792

Closed
brianjmurrell opened this issue Jun 20, 2017 · 4 comments
Closed

option to configure a domain name per network #792

brianjmurrell opened this issue Jun 20, 2017 · 4 comments

Comments

@brianjmurrell
Copy link
Contributor

One can add a <domain name='example.com' localOnly='yes'/> type stanza to a libvirt network configuration to have that network's dnsmasq answer DNS queries for that network as is blogged about here.

This would be very useful.

Barring actually implementing this, a similar option to #791 for networks would be a useful stop-gap.

@electrofelix
Copy link
Contributor

Actually I'd find that feature very handy as it would remove a requirement on using vagrant-hostmanager locally and make a container with vagrant/vagrant-libvirt easier to use.

I'll try to see what's required over the next week, but it's probably as easy as adding a domain option to the network config options and updating the associated template. Trickier might be restricting usage to additional networks (should not be allowed for the management one i'd say, as too easy to conflict with multiple setups), and catching attempting to redefine a network used by another set of vm's.

@infernix
Copy link
Member

infernix commented Aug 3, 2017

PRs are welcome! :)

@hugoboos
Copy link
Contributor

Hi, created #833. First attempt, work in progress, feedback is welcome.

@syndbg
Copy link

syndbg commented Dec 21, 2018

I think this can be closed @infernix since #833 is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants