Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBaseKoaProxiesOptions Should Extend http-proxy Server.ServerOptions #68

Open
RavenHursT opened this issue Jun 14, 2022 · 0 comments
Open

Comments

@RavenHursT
Copy link

Shouldn't this line include extends Server.ServerOptions from the http-proxy package?
https://github.com/vagusX/koa-proxies/blob/master/index.d.ts#L7

Considering the fact that it looks like the options object is being passed along wholesale to http-proxy, seems like it would make sense: https://github.com/vagusX/koa-proxies/blob/master/index.js#L65-L70 and https://github.com/vagusX/koa-proxies/blob/master/index.js#L109

I was trying to add the buffer option (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/http-proxy/index.d.ts#L187), but TS is choking on the missing property on IBaseKoaProxiesOptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant