Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.2 deprecation message "Creation of dynamic property" #104

Closed
michaelarnauts opened this issue Feb 7, 2023 · 3 comments · Fixed by #105
Closed

PHP 8.2 deprecation message "Creation of dynamic property" #104

michaelarnauts opened this issue Feb 7, 2023 · 3 comments · Fixed by #105

Comments

@michaelarnauts
Copy link

A clear and concise description of what the bug is.

Pre-requisites

  1. Use PHP 8.2

To Reproduce
Steps to reproduce the behavior:

  1. Install the package

Actual
The output of composer install contains this warning:

Deprecation Notice: Creation of dynamic property Vaimo\ComposerPatches\Patch\File\Applier::$applierErrorFactory is deprecated in /opt/app/vendor/vaimo/composer-patches/src/Patch/File/Applier.php:63
@hostep
Copy link
Contributor

hostep commented Feb 23, 2023

Yep, also running into this.
It's just a warning, but still, would be nice to see this fixed soon-ish (Magento 2.4.6 comes with PHP 8.2 support and will be released in about 3 weeks) 🙂

Thanks!

@hostep hostep mentioned this issue Feb 23, 2023
Merged
@zamoroka
Copy link
Contributor

zamoroka commented Mar 9, 2023

@hostep @michaelarnauts thanks for your contribution. The fix is released in 5.1.1

@hostep
Copy link
Contributor

hostep commented Mar 9, 2023

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes PHP 8.2 deprecation notice hostep/composer-patches
3 participants
@hostep @michaelarnauts @zamoroka