Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lastest nuget version doesn't contain the latest fix #15

Closed
kvpt opened this issue Jun 8, 2020 · 2 comments
Closed

Lastest nuget version doesn't contain the latest fix #15

kvpt opened this issue Jun 8, 2020 · 2 comments

Comments

@kvpt
Copy link

kvpt commented Jun 8, 2020

Hi @vain0x,

After updated to the latest version of the nuget package, I still have the issue fixed by my PR on my app.
So I used DotPeek to uncompile the latest version and found that the code doesn't contain my latest fix.

Uncompiled version :
image

Current source :

var count = CountWithMax(ItemsSource?.Cast<object>() ?? Enumerable.Empty<object>(), filter, maxCount);

I don't think this is intended, so can you release a new version with the fix ?

Thank you.

vain0x added a commit that referenced this issue Jun 8, 2020
@vain0x
Copy link
Owner

vain0x commented Jun 8, 2020

@kvpt Sorry and thank you for pointing out!

@vain0x vain0x closed this as completed Jun 8, 2020
@kvpt
Copy link
Author

kvpt commented Jun 8, 2020

@vain0x No problem, errors happen and it's a free time project so no warranty.
Thanks you again for your responsiveness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants