Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi-line (>250 chars) support for long boosts into IRC messages #13

Merged
merged 8 commits into from Apr 12, 2022

Conversation

dowodenum
Copy link
Contributor

Pretty simple, chunks() separates a long string into a list of strings, each element having a length no longer than 250. Then iterate through that list and send each chunk as an IRC message.

Copy link
Owner

@valcanobacon valcanobacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Could you add some type annotations. A unit test for chunk would be great. Have you manually tested this?

src/irc/__init__.py Outdated Show resolved Hide resolved
src/irc/__init__.py Outdated Show resolved Hide resolved
@dowodenum
Copy link
Contributor Author

image

Copy link
Owner

@valcanobacon valcanobacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thanks!

@valcanobacon valcanobacon merged commit 73cfcc3 into valcanobacon:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants