Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSE Review: Typos, URLs #7

Closed
lechten opened this issue Feb 14, 2022 · 8 comments
Closed

JOSE Review: Typos, URLs #7

lechten opened this issue Feb 14, 2022 · 8 comments

Comments

@lechten
Copy link

lechten commented Feb 14, 2022

This is related to your JOSE submission.

  • In Acknowledgements, a closing parenthesis is missing (after “(BITSS)”?).
  • L. 96, “The resource is designed to scaffold reproducible and transparent research workflow”: Should this be “a” workflow or “workflows”?
  • The checklist asks for DOIs. Not all papers have one. Did you check? Note that the URL in Lau et al. is not formatted as hyperlink.
  • The URL in Guzharina is too long. It should be broken, maybe at “-”.
@valdanchev
Copy link
Owner

Thank you for the helpful comments, which I have addressed:

  • corrected the typos
  • added DOIs for almost all papers (except for Hagberg et al which does not seem to be available)
  • formated the URL in Guzharina to fit

@lechten
Copy link
Author

lechten commented May 19, 2022

I just tried to generate a new PDF for the JOSE issue, which failed, probably due to the subdirectory. Do you know how to do that?

@valdanchev
Copy link
Owner

Many thanks! Just renamed the subdirectory to paper, which hopefully solves this; if not, another option would be to place the paper files outside the subdirectory.

@lechten
Copy link
Author

lechten commented May 19, 2022

Thanks! Now there is a ruby exception...

I have no idea whether this is a general issue or related to your paper.

@lechten
Copy link
Author

lechten commented May 19, 2022

Actually, that is probably the ":" in the title. Maybe replace with emdash? Or quote somehow?

@valdanchev
Copy link
Owner

Totally, thanks, added quotes.

@lechten
Copy link
Author

lechten commented May 20, 2022

Thank you for the update. I asked for the PDF at JOSE...

@lechten
Copy link
Author

lechten commented Jun 23, 2022

Thank you for your patience. With the new PDF, everything seems fine to me. Closing this.

@lechten lechten closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants