Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use sudo with your script without warning #9

Closed
truatpasteurdotfr opened this issue May 11, 2021 · 2 comments
Closed

don't use sudo with your script without warning #9

truatpasteurdotfr opened this issue May 11, 2021 · 2 comments

Comments

@truatpasteurdotfr
Copy link

Please, as a courtesy to your users, do not hide the sudo commands in your install.sh script.

If needed ask them to re-run ./install.sh with sudo.

@Valdes-Tresanco-MS
Copy link
Owner

Thanks @truatpasteurdotfr

We try to be as transparent as possible. Since AMDock was our first software, it may have some problems of this kind. According to the vulnerability analysis, AMDock does not present any, however, I will try to modify install.sh or be more explicit in the documentation.

The installation of AMDock requires access to the system's Python modules folder as this folder requires administrator write rights. We could modify it to install in an external folder that does not require the sudo command, but it would increase the risk of conflicts in PYTHONPATH variable

The new version of AMDock is modular, so this will not be required.
Thank you very much for the suggestions, we will certainly take them into account

Best!
Mario S.

@truatpasteurdotfr
Copy link
Author

We have quite a lot of python, pymol installed side by side and unless it is your own laptop/development machines, users are seldom allowed to "sudo". If you have users using conda, they already own the python libraries and don't need sudo for installing additionnal librairies. Furthermore, running sudo without being authorised, is usally ringing an alarm for the sysadmin.
Just my 2 cents.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants