Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse named text colors. #21

Closed
rj00a opened this issue Sep 4, 2022 · 0 comments · Fixed by #23
Closed

Parse named text colors. #21

rj00a opened this issue Sep 4, 2022 · 0 comments · Fixed by #23
Labels
good first issue Good for newcomers

Comments

@rj00a
Copy link
Member

rj00a commented Sep 4, 2022

In the text module, text colors can be named like "black", "gold", "red" or they can be a precise six-digit hex color like "#000000".

The current deserializer fails if it encounters one of the named colors, but it should be accepted.

I think it's fine to normalize them to hex colors during serialization though.
@rj00a rj00a added the good first issue Good for newcomers label Sep 4, 2022
@TheEternalShine TheEternalShine mentioned this issue Sep 5, 2022
Merged
@rj00a rj00a closed this as completed in #23 Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add named text color parsing TheEternalShine/valence
1 participant
@rj00a