Replace for item in query with query.for_each

[rj00a]

Describe the problem related to your feature request.

Query::for_each is known to be significantly faster than Query::iter due to rustc failing to optimize properly.

What solution would you like?

Replace all uses of .iter()/.iter_mut()/&/&mut with .for_each/.for_each_mut where feasible.

What alternative(s) have you considered?

Don't do this since it could be considered a temporary rustc failure that will be fixed in the future. (But when will it be fixed?)

Additional context

Not sure if there's an open bevy issue for this.

[rj00a]

rust-lang/rust#104914

Yes, that's a long-known issue (see the blog post linked previously) but there aren't any good plans how to fix it.

[rj00a]

bevyengine/bevy#6773 plans to deprecate Query::for_each.

[Milo123459]

as bevy is planning to deprecate it, should we not just leave it as is as it is an upstream issue.

[rj00a]

Yeah, I would rather not make any changes until bevyengine/bevy#6773 comes to a conclusion.

[Milo123459]

yeah, also i presume some members of the bevy community are going to see the upstream issue and can hopefully help out to fix it upstream (in the rust repo.)