Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reply payload retrieval and checking #73

Closed
YurBoiRene opened this issue Sep 22, 2023 · 1 comment
Closed

Add reply payload retrieval and checking #73

YurBoiRene opened this issue Sep 22, 2023 · 1 comment

Comments

@YurBoiRene
Copy link

A part of the ping command is that it sends a fixed payload and then will report an error if the returned data is different than the data sent.

I noticed in icmplib you can send an arbitrary payload after the ICMP header but there is no support for reading the returned payload or checking if it is the same.

I would propose adding payload property to the ICMPReply class as well as possibly a "valid packets" property in the Host class to report the number of packets that sent valid/invalid data back.

If you're interested in having this as a feature, I would be happy to implement and make a pull request.

@ValentinBELYN
Copy link
Owner

Hi @YurBoiRene,

Thanks for the suggestion. However, this is not planned at the moment.

@ValentinBELYN ValentinBELYN closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants