Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Module upload version bug #36

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Fix Module upload version bug #36

merged 1 commit into from
Aug 3, 2022

Conversation

vincentgna
Copy link
Contributor

@vincentgna vincentgna commented Aug 3, 2022 •
edited

Ideally unit tests would catch these bugs

fixes #35

@vincentgna
Fix bug in module version upload
46998be 
Ideally unit tests would catch these bugs
@vincentgna vincentgna changed the title Fix #35 Fix Module upload version bug Aug 3, 2022
valentindeaconu
valentindeaconu approved these changes Aug 3, 2022
View reviewed changes
Copy link
Collaborator

@valentindeaconu valentindeaconu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Ideally unit tests would catch these bugs

After all core functionalities are implemented, I will take some time to properly test all of those components and implement some unit tests.

@valentindeaconu valentindeaconu merged commit 9f02907 into terralist:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentindeaconu valentindeaconu valentindeaconu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: existing module new version upload always return "version already exists" error
2 participants
@vincentgna @valentindeaconu