Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rework resolver flow for modules #40

Merged
merged 8 commits into from
Aug 22, 2022

Conversation

valentindeaconu
Copy link
Collaborator

@valentindeaconu valentindeaconu commented Aug 18, 2022

This PR reworks the resolver flow for modules.

Tasks:

  • Extract URL downloading from resolvers (their job is to manage the storage, not to download files);
  • Rework the file package to work with files in memory (since their content is required to be uploaded to the remote storage);

The go-getter implementation was also reworked since the old implementation was not suitable for providers (checksum mismatch, the reason for #14)

  • Move resolver logic from the repository to service for modules;
  • Update ModuleService.Upload signature to take the URL as argument, preparing it to also accept InMemoryFiles (file uploading - subject of a future PR);

@valentindeaconu valentindeaconu force-pushed the chore/move-resolver-logic-to-service branch from e1ebe83 to 399b1c2 Compare August 18, 2022 15:15
@valentindeaconu valentindeaconu marked this pull request as ready for review August 20, 2022 12:01
@valentindeaconu valentindeaconu merged commit 4148fa5 into master Aug 22, 2022
@valentindeaconu valentindeaconu deleted the chore/move-resolver-logic-to-service branch August 22, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant