Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: is it worth gzcompress the events list? #5

Open
mudrd8mz opened this issue Dec 18, 2017 · 2 comments
Open

Performance: is it worth gzcompress the events list? #5

mudrd8mz opened this issue Dec 18, 2017 · 2 comments

Comments

@mudrd8mz
Copy link

I can imagine the list of events is typically quite short as the external system is interested in particular events only. I am wondering if the constant decompressing is actually needed as it happens for every record in the table, on every page request. On bigger sites, this might have negative impact on the performance.

@mudrd8mz
Copy link
Author

This might be solved together with the #4 and a better system for locating the appropriate webhook for the given event might be implemented as a part of cached structure - without the need to iterate over all records and uncompressing the events list.

@valentineus
Copy link
Owner

A good idea.
Rewrote the internal functions of the plugin, removed the compression.

I am considering the possibility to add caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants