Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed actions, simplified store #1

Merged
merged 58 commits into from
Nov 5, 2022
Merged

Removed actions, simplified store #1

merged 58 commits into from
Nov 5, 2022

Conversation

valentinradu
Copy link
Owner

  • removed actions, allowing side-effects to be performed directly from the store
  • greatly simplified the store by making it an ObservableObject and @MainActor

Valentin Radu added 30 commits June 14, 2022 19:13
Initial attempt to make actions structs
2c877bd
Working substore version
ba31a43
Working substore version
51d3477
Added .swiftformat. Finished design. First test pass
5e871d3
Added some basic tests
5d9d801
Formatting
d40cb5f
Fixed the remaining (3) tests
9bce07f
Made environment private
869652c
Made environment private
ca34fe3
Made PartialStore public
cb03c53
Made state public in store
972c9d0
Added convenience initializer for Store
766f440
Moved environment to non-protocols
4c71368
Better use generics to describe pure mutations
72257d3
Audit public/private API
a5ce06a
Added init for side effect
c0b9e49
Iterated public API
cc217be
Made mutations hashable
281348f
Moved to protocol based side-effects
9b5150c
Made SideEffect a protocol. Added composable side effects
3e900ae
Added actions as a way to call side effects directly
7a54441
Empty -> Noop, Reducer -> Dispatcher
5749125
Made AnySideEffect and AnyMutation public
e28b699
asAnyMutation -> asAnySideEffect
e73e647
Revert "Empty -> Noop, Reducer -> Dispatcher"
a058b63 
This reverts commit 5749125.
Renamed mutation to mut and environment to env
7bd6c99
Added InlineMutation and InlineSideEffect
9da9a1a
Fixed InlineMutation and InlineSideEffect public init
4b3800a
Made InlineSideEffect init closure async throws
b574597
Inline effect is not accepting a builder closure anymore
62c71a4
Valentin Radu added 27 commits June 22, 2022 13:50
Remove InlineMutation, added @SideEffectBuilder for the InlineSideEff…
d5d679c 
…ect closure
Aaaan removed @SideEffectBuilder
0a99a41
asAny* are functions now
c3d3566
Made AnyAction public
1580717
renamed the protocols (e.g. SideEffect -> SideEffectProtocol), remove…
80d73e1 
…d the partial store
Made action, mutations and side effects wrapping initializers a closure
8847009
Removed closures for wrapping Actions/Mutations/SideEffects
4534ccb
Added major hack to make closures somehow equtable based on the calli…
d1a5de7 
…ng point
Added #line in the hack hashing algorithm of the action/mutation
d66683b
Fixed line identity
ceb479b
Made state and env public in the store
06f8efd
Removed ability to catch all errors, forcing the cosumer to handle th…
7e04f2e 
…em locally
Cleaned up tests
b80d8a6
Added ingest method to process an async sequence of mutations or actions
6c722d0
Action now has state
15493b9
Ensure main thread state updates
ca27130
Used plain publisher for will change
cc74ad2
Use plain callback for willChange
121682a
Added assertion for willChange empty implementation
72a471f
Removed Hashable deps
66fd8d3
Enable SideEffect Groups
9e677b5
Removed SideEffect.noop limitations
dfc08bc
Removed Mutation.noop limitations
e171a14
Improved threading for state updates
d034bb5
Added didChange
50c18f9
Moved away from async sequences towards combine + publishers
74cb503
Removed actions, simplified store
f160a27
@valentinradu valentinradu self-assigned this Nov 5, 2022
@valentinradu valentinradu merged commit fc90d54 into main Nov 5, 2022
@valentinradu valentinradu deleted the removed-actions-simplified-store branch November 5, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@valentinradu valentinradu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@valentinradu