Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-fetch.js should treat status 308 as a redirect #57

Closed
denishowew opened this issue Oct 9, 2020 · 1 comment
Closed

node-fetch.js should treat status 308 as a redirect #57

denishowew opened this issue Oct 9, 2020 · 1 comment

Comments

@denishowew
Copy link

PR 55 added support for HTTP status 307 (temporary redirect with no change of method).
Should all 3XX codes be treated as redirects? Certainly my current favourite,
308 (permanent redirect), should.

Also not recognised:

  • 300 Multiple Choices
  • 304 Not Modified
  • 305 Use Proxy
@valeriangalliat
Copy link
Owner

Hey! I just published fetch-cookie@2.0.0 with an improved redirect logic and now handles all of those redirect statuses. It should basically behave the same as node-fetch as far as redirects are concerned now. Cheers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants