Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tyr::actor_t: curl as a requirement #1408

Closed
rinigus opened this issue Jul 10, 2018 · 4 comments
Closed

tyr::actor_t: curl as a requirement #1408

rinigus opened this issue Jul 10, 2018 · 4 comments

Comments

@rinigus
Copy link
Contributor

rinigus commented Jul 10, 2018

It looks like libcurl is required by Valhalla lib when using tyr::actor_t even if it is compiled with

cmake .. -DCMAKE_INSTALL_PREFIX:PATH=/usr -DBUILD_SHARED_LIBS=OFF -DBUILD_STATIC_LIBS=ON -DENABLE_DATA_TOOLS=OFF -DENABLE_PYTHON_BINDINGS=OFF -DENABLE_SERVICES=OFF

Is there any reason for it or is it just remains of HTTP API?

@kevinkreiser
Copy link
Member

yes its because the GraphReader has the ability to get tiles from http via curl. we can add another flag to the build to disable that functionality and not require curl at all in that case

@rinigus
Copy link
Contributor Author

rinigus commented Jul 10, 2018

Well, it doesn't bother me, as such. At least its clear that this lib is needed and its not some mistake. I presume that all curl initialization is done by Valhalla, if needed. Or should we be aware of it and call easy init function(s)?

Please feel free to close the issue if you wish.

@kevinkreiser
Copy link
Member

yes it takes care of the init and deinit of curl automatically without you needing to see here: https://github.com/valhalla/valhalla/blob/master/valhalla/baldr/curler.h

@rinigus
Copy link
Contributor Author

rinigus commented Jul 10, 2018

Excellent! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants