Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ferry relations are ignored, e.g. to island Sylt #4381

Open
OptiMael opened this issue Nov 3, 2023 · 11 comments
Open

Ferry relations are ignored, e.g. to island Sylt #4381

OptiMael opened this issue Nov 3, 2023 · 11 comments
Labels

Comments

@OptiMael
Copy link

OptiMael commented Nov 3, 2023

Routing in this example ignores the car shuttle train SyltShuttle.

The changes leading to this issue were made here and discussed in this thread .

Are there any plans for Valhalla to adopt the new proposal?

@nilsnolde
Copy link
Member

Can you please boil down the "proposal" to a few sentences?

We do train ferries generally, but we also do have a few issues with ferry connections, specifically with islands as well, which are being worked on. You might wanna try this branch: #4378.

@OptiMael
Copy link
Author

OptiMael commented Nov 3, 2023

As I understand the original idea was to consider a relation with tag route=shuttle_train connected to a Car_shuttle node as a possible route.

Edit: Compared to a ferry, the Car_shuttle seems to be the equivalent to a ferry_terminal

@nilsnolde
Copy link
Member

Ah interesting! No, we don't respect that yet. Thanks for flagging it though. Even the eurotunnel does this now?

@OptiMael
Copy link
Author

OptiMael commented Nov 3, 2023

That's correct.
Valhalla seems to always use the ferry at Calais (France) instead of the chunnel.

@nilsnolde
Copy link
Member

Ah wait, no, the problem must be smth else. We don't care about those nodes, it should still work as-is. Maybe it'll be one of the PRs that are already merged or will be merged very soon. I also didn't update the software on the public server in a longer while.

@nilsnolde nilsnolde added bug and removed enhancement labels Nov 3, 2023
@nilsnolde
Copy link
Member

@OptiMael can you point us to the actual OSM way that should be used as route=shuttle_train for car travel for the Sylt line? I seem to be blind, I only see this way (+ some rails): https://www.openstreetmap.org/way/310476567#map=13/54.8782/8.5370

@OptiMael
Copy link
Author

OptiMael commented Nov 3, 2023

@nilsnolde
Parent: https://www.openstreetmap.org/relation/15617114
Child 1 (to island): https://www.openstreetmap.org/relation/6377345
Child 2 (to mainland): https://www.openstreetmap.org/relation/6384504

@kevinkreiser
Copy link
Member

kevinkreiser commented Nov 3, 2023

disclaimer i didnt debug this or review code at all

yeah if all the tagging is on the relation then that isnt going to work. we do process relations but only for vanity information like route numbers. for this to work today the member ways of the relations need to be tagged with something that makes the router think our modes of travel have access. it looks to me like only the relation has this tagging and so we dont use it

@nilsnolde
Copy link
Member

jep, that's why I didn't see them:) the same very surely goes for all other routing engines. correct me if I'm wrong, but I don't know any convention for other cases where these highly routing-sensitive tags are only on the relations.. it's like putting a highway=motorway on motorway relations and not tagging the members.

@kevinkreiser
Copy link
Member

that would be my opinion yes. basically this is tagged wrong. maybe there is a special convention that im not aware of?

@nilsnolde nilsnolde added wontfix and removed bug labels Nov 5, 2023
@nilsnolde nilsnolde changed the title Routing issue from mainland Germany to island Sylt Ferry relations are ignored, e.g. to island Sylt Nov 5, 2023
@nilsnolde
Copy link
Member

It’s very much walking the line of “don’t tag for the router”, but (speaking exclusively for myself), there’s a limit to what OSM downstream software should be burdened with maintaining.

@OptiMael is there a chance to re-tag those members? I’m fairly confident in saying, hardly any router will implement ferry relations just to save a few bytes. And this kind of relation is really only existing to save bytes, there’s nothing relational about it (like turn restrictions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants