Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tyr OSRM serializer needs voiceInstructions in step #4482

Closed
eikes opened this issue Dec 28, 2023 · 3 comments · Fixed by #4506
Closed

Tyr OSRM serializer needs voiceInstructions in step #4482

eikes opened this issue Dec 28, 2023 · 3 comments · Fixed by #4506

Comments

@eikes
Copy link
Contributor

eikes commented Dec 28, 2023

There is a proprietary extension of the OSRM routing format used in the Mabox Navi SDK and MapLibre Navi SDK, both in iOS and Android. These SDKs work better when the voiceInstructions attribute is present in the steps. Valhalla should have support for these voiceInstructions.
@kevinkreiser
Copy link
Member

yep been meaning to do it for years but never got around to it

@eikes
Copy link
Contributor Author

eikes commented Dec 29, 2023

already working on it, PR ready soon: https://github.com/eikes/valhalla/tree/voice-instructions

@kevinkreiser
Copy link
Member

🙏

@eikes eikes mentioned this issue Jan 12, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OSRM Serializer: Adds voice instructions eikes/valhalla
2 participants
@eikes @kevinkreiser