Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make as many third_party libs as possible optional #4529

Closed
nilsnolde opened this issue Jan 25, 2024 · 1 comment · Fixed by #4544
Closed

Make as many third_party libs as possible optional #4529

nilsnolde opened this issue Jan 25, 2024 · 1 comment · Fixed by #4544
Labels

Comments

@nilsnolde
Copy link
Member

nilsnolde commented Jan 25, 2024

while it's very convenient for us, it's not compatible with general package managing rules, to have public interface depending on vendored libraries. I guess all libs only used in tests are fine, no one wants to package (our) tests. this could also be (partly, see below) solved by removing those headers from our public interface which would be a great thing to do anyways.

I'll still need to confirm, but I think even compile-time header-only libs are at least frowned upon. because of security implications and possibly licensing problems.

@nilsnolde
Copy link
Member Author

Scope changed a bit: removing them is too much. Making their usage optional is how I should’ve phrased it.

@nilsnolde nilsnolde changed the title remove third_party libs as much as possible Make as many third_party as possible optional Feb 4, 2024
@nilsnolde nilsnolde changed the title Make as many third_party as possible optional Make as many third_party libs as possible optional Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant