Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Cannot legalize G_STORE #3

Closed
maxgillett opened this issue Apr 3, 2023 · 4 comments
Closed

Cannot legalize G_STORE #3

maxgillett opened this issue Apr 3, 2023 · 4 comments

Comments

@maxgillett
Copy link
Member

Compiling the following program using the command llc func.ll --global-isel --march=delendum --stop-after=legalizer:

; func.ll
define void @f(i32 %a, i32 %b) {
  ret void
}

results in a memory exception when LegalizeRuleSet::getAlias is called.

@0x59616e
Copy link
Collaborator

0x59616e commented Apr 3, 2023

May I kindly ask your preference over GlobalISel and SelectionDAG as the driver of the code generator ?

@maxgillett
Copy link
Member Author

May I kindly ask your preference over GlobalISel and SelectionDAG as the driver of the code generator ?

My understanding is that GlobalISel is expected to eventually replace SelectionDAG, and is easier to work with (both in LOC required to implement code generation, and in testing). What is your opinion, and are there pitfalls that I'm overlooking?

@0x59616e
Copy link
Collaborator

0x59616e commented Apr 4, 2023

I'm 100% go into GlobalISel since it is more easier to debug and test with.

and are there pitfalls that I'm overlooking?

One of the minor drawbacks when I was working on it in 2021 was the lack of certain pattern matching support from TableGen, which didn't bother since you can write with C++.

@maxgillett
Copy link
Member Author

Fixed in 4e20325

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants