Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMM32: Add missing range check #73

Open
morganthomas opened this issue Oct 29, 2023 · 2 comments
Open

IMM32: Add missing range check #73

morganthomas opened this issue Oct 29, 2023 · 2 comments

Comments

@morganthomas
Copy link
Collaborator

morganthomas commented Oct 29, 2023 •
edited

The constraints for immediate values are missing a range check on read_value_2, in the implementation of Air<AB>::eval in cpu/src/stark.rs. The comment says:

Immediate value constraints (TODO: we'd need to range check read_value_2 in this case)
@HegelXu
Copy link

HegelXu commented Apr 11, 2024

Excuse me, can I implement the range check function?

@morganthomas
Copy link
Collaborator Author

@HegelXu , go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@morganthomas @HegelXu