isEmail fails with valid gmail address

[fredrik-smedberg]

isEmail returns false for this address: Ulises_Morar20@gmail.com

[RobertFischer]

Confirmed.

$ yarn add validator
yarn add v1.7.0
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency.
info Direct dependencies
└─ validator@10.4.0
info All dependencies
└─ validator@10.4.0
Done in 0.59s. 
$ node
> const isEmail = require("validator/lib/isEmail");
undefined
> isEmail("Ulises_Morar20@gmail.com");
false
> 

Confirmed.

See also: #825 and #853.

Looks like it's because the Gmail user validation doesn't allow underscores: https://github.com/chriso/validator.js/blob/9ad2034dceb340ac2f9d9103d392a19f4cffa785/src/lib/isEmail.js#L18 A quick trip around the internet confirms that this is, in fact, the case: Gmail doesn't let you create a username with an underscore. So that is, in fact, a valid email.

[agsdtm7]

same thing here with normal gmail without underscore

also doesn't work

[tux-tn]

@agsdtm7 your email is not valid, minimal address length for gmail is 6 characters.

[agsdtm7]

you are correct now it worked with 6 characters (or more) gmail addresses. Thanks for speedy reply

[patelnav]

@RobertFischer
I ran into the same issue when testing things internally. Turns out gmail doesn't usually allow underscores, this validation was added on this commit.

@tux-tn:
2 reasons why this shouldn't be enforced:

1. Google doesn't specifically say this is enforced. So it doesn't makes sense for a client-side validator to enforce this. Even google in their Examples of regular expressions don't enforce this.

2. Some of my demo accounts (with dummy email addresses) have underscores @gmail.com. I can no longer log in because validator is blocking it client side! Just a bit of a pain!

[chriso]

@patelnav see #832 (comment) for an example of gmail restricting usernames to [6,30] chars. Admittedly though, I don't know if this was always the case, or if there are valid, internal gmail addresses with < 6 chars.

Either way, this has caused too many issues. I'll add a flag to control the behavior and default to the previous implementation.

[oliviertassinari]

@agsdtm7 your email is not valid, minimal address length for gmail is 6 characters.

Does is mean Larry (Page) can't sign in in my application using validator.js? Hum, unless he is using larry@google.com :)