Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename: forking deps/hiredis #192

Open
0del opened this issue Apr 4, 2024 · 4 comments
Open

Rename: forking deps/hiredis #192

0del opened this issue Apr 4, 2024 · 4 comments

Comments

@0del
Copy link
Contributor

0del commented Apr 4, 2024 •
edited by zuiderkwast

There is no decision about this yet.

It is used by valkey-cli and valkey-benchmark.

As long as hiredis is vendored, we shall probably avoid changing anything in it, since it would make our vendored version diverge from the upstream hiredis. We can consider forking it though.
@0del 0del mentioned this issue Apr 4, 2024
Closed
18 tasks
@0del 0del changed the title Renaming: forking deps/hiredis Rename: forking deps/hiredis Apr 4, 2024
@0del
Copy link
Contributor Author

0del commented Apr 4, 2024 •
edited

i can't assign this issue to myself, please help me @zuiderkwast

@zuiderkwast
Copy link
Contributor

There is no decision about this yet, so please hold off. Maybe we'll do it in a future release I would say. There are some drawbacks, like being unable to update it if if hiredis is improved upstream. It's still BSD.

@0del
Copy link
Contributor Author

0del commented Apr 4, 2024 •
edited

i see, let me know and then we can update, i will be happy to help.

@zuiderkwast
Copy link
Contributor

@michael-grunder

@zuiderkwast zuiderkwast mentioned this issue Apr 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zuiderkwast @0del