Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Developer Certificate of Origin #38

Closed
madolson opened this issue Mar 26, 2024 · 4 comments · Fixed by #48
Closed

Addition of Developer Certificate of Origin #38

madolson opened this issue Mar 26, 2024 · 4 comments · Fixed by #48

Comments

@madolson
Copy link
Member

I've gone ahead and added a DCO check for our version. We want to make sure we aren't unintentionally pulling in code from either redict (which is LGPL) or Redis (which is now RSAL and SSPL).

All that is required is for the commit to contain Signed-off-by: Full Name <email>. Starting this thread to raise any concerns about the issue.

@leo60228
Copy link

Is a full name required for contributions? The Linux kernel and CNCF simply require a "known identity."

@madolson
Copy link
Member Author

This was the language I was suggested, with the clarification doesn't that Full Name doesn't need to be your legal name, just one that you go by. So, for now "known identity" seems fine by me, but I'll go chat with some folks about it.

@madolson madolson linked a pull request Mar 27, 2024 that will close this issue
@madolson
Copy link
Member Author

Went with the wording, "We require the usage of known identity (such as a real or preferred name). We do not accept anonymous contributors nor those utilizing pseudonyms." Which seemed inclusive to everyone I could think of.

@nonnull-ca
Copy link

Saddening, but understandable, speaking as somebody who almost entirely contributes (pseudo)anonymously to OSS projects for liability reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants