-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The output of INFO server #41
Comments
Consider checking with Sidekiq - https://github.com/search?q=repo%3Asidekiq%2Fsidekiq%20redis_version&type=code The maintainer of the framework may even agree to change the code to adapt to both standards but it will still be a problem for older versions of the library. |
@romange Thx. We'll keep the In addition to that, we'll add |
As far as I know,
I think we should start a separate thread to let sdk/tool developers report their commands or fields that depend on Redis. (If possible, the best approach is to not change these old fields) |
I'm been thinking a bit about these new "server_version" and "server_name" fields in INFO. Ideally, services and forks based on valkey should be able to show their own names, e.g. "server_name:elastcache" or "server_name:foo" and then it may be useful to say which valkey version and which redis version it's compatible with. One possibility is to follow redis style and just add "NAME_version" fields for each projects it's compatible with, like this:
It's not a clear idea, just a problem that we may want to solve before releasing these new fields. Another possibility could be to use something like User-Agent string browser have, which the clients can parse if we introduce it and explain it from start, while keeping the legacy "redis_version" field, e.g.
A 3rd variant, something between the two above:
|
The command
INFO
includes the following lines:Clients use this information to find out which version the server is running and from this they can conclude which features it supports.
The question is whether API compatibility justifies using a trademark name in the output of the command.
We have some alternatives:
The text was updated successfully, but these errors were encountered: