Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CLEU to it's own frame handler #75

Closed
orionshock opened this issue Dec 13, 2022 · 3 comments
Closed

Move CLEU to it's own frame handler #75

orionshock opened this issue Dec 13, 2022 · 3 comments

Comments

@orionshock
Copy link

orionshock commented Dec 13, 2022

Can you move CLEU to it's own frame and event handler. I did this to my local copy and it improved my frame rate by at least 20.

    local frame = CreateFrame("Frame")
    frame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
    frame:SetScript("OnEvent", function() addon:COMBAT_LOG_EVENT_UNFILTERED() end)

is all you need in the OnEnable()

@SabreValkyrn
Copy link
Member

SabreValkyrn commented Dec 13, 2022

Not sure I understand that reasoning.

Aside from using native frames instead of AceEvent wrapper, there shouldn't be a difference.

@SabreValkyrn
Copy link
Member

Brought this up with another dev, he traced it down to

  • it's not AceEvent it's CBH
  • 2x next() calls, 1x xpcall

Thanks for bringing this to my/our attention, I'll make the optimization today

@orionshock
Copy link
Author

Also your CLEU handling needs optimization.
With out the addon loaded, I can get ~75fps in Dalaran. With it turned on I'm at ~35fps.

The order of operations inside CLEU should bail as early as possible so that it's not doing a lot of useless checks before realizing the player is idle out of group.

CLEU is a very very chatty event and it shouldn't be causing such a FPS loss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants