Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Django 3.0 (/ drop support for Python 2.7) #84

Closed
hailkomputer opened this issue Dec 4, 2019 · 4 comments
Closed

Support Django 3.0 (/ drop support for Python 2.7) #84

hailkomputer opened this issue Dec 4, 2019 · 4 comments
Labels

Comments

@hailkomputer
Copy link
Contributor

Hi, I am currently evaluating upgrading a project to Django 3 and allauth-2fa is incompatible because dropped support of django.utils.six in version 3.

https://docs.djangoproject.com/en/3.0/releases/3.0/#removed-private-python-2-compatibility-apis

Here is a traceback of running allauth-2fa with Django 3.

|   File "/usr/local/lib/python3.7/site-packages/allauth_2fa/utils.py", line 8, in <module>
|     from django.utils.six import BytesIO
| ModuleNotFoundError: No module named 'django.utils.six'

Any plans to migrate to six and give support to Django 3?

Thank you

@clokep
Copy link
Collaborator

clokep commented Dec 4, 2019

It is on my todo list to drop support for Python 2 at some point across a few projects. I don't think I'll get to it soon though, so any help would be appreciated. It is rather unfortunate that both Django 1.11 and Django 3 are currently "supported" but code can't be written to support both of them (while supporting Python 2 and Python 3). 👎

@clokep clokep changed the title django.utils.six has been dropped in Django v3 Support Django 3.0 (/ drop support for Python 2.7) Dec 4, 2019
@dmptrluke
Copy link
Contributor

Can we have a release with this change in place?

@gtaylor
Copy link

gtaylor commented Jan 24, 2020

Before I take the hacksaw out and start lopping: will small PRs that shed Python 2.x cruft be accepted? Probably not going to be pragmatic for me to do the Python 2.x removal in one mega PR.

@clokep
Copy link
Collaborator

clokep commented Jan 28, 2020

@gtaylor Thanks for commenting. I believe this work was done in #86 and I failed to close this issue!

I haven't had time yet to do a release with the changes however.

@clokep clokep closed this as completed Jan 28, 2020
@clokep clokep added the feature label Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants