Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag release for CocoaPods #33

Closed
bgiori opened this issue Dec 18, 2018 · 8 comments
Closed

Tag release for CocoaPods #33

bgiori opened this issue Dec 18, 2018 · 8 comments

Comments

@bgiori
Copy link
Contributor

bgiori commented Dec 18, 2018

Hi Greg,

I will be using SwiftCBOR in a framework that I am helping build. The package manager we have chosen is CocoaPods which unfortunately does not allow pulling in source dependencies in the podspec (this issue was also brought up in #7).

Since there have been a number of changes since 0.2.0, could you tag a new release?

Thanks,
Brian

@valpackett
Copy link
Owner

Does cocoapods just need a git tag in the git repo, or something else?

@bgiori
Copy link
Contributor Author

bgiori commented Dec 18, 2018

I am by no means a CocoaPod expert, but based on this line in the podspec,

s.source = { :git => 'https://github.com/myfreeweb/SwiftCBOR.git', :tag => 'v0.2.0' }

It looks like it is referring to a specific git tag (not necessarily a github release) when pulling in the source. You may be able to specify a specific commit :commit => 'xxxxxxxxxx' but (a) I'm not sure that will work, and (b) it probably best practice to match the version of the pod and the most recent tag.

So to answer your question, yeah, just a git tag :)

@valpackett
Copy link
Owner

I tagged v0.3.0. But looking at past discussions, looks like it (the updated podspec) actually needs to be submitted to cocoapods itself. @brycehammond?

does not allow pulling in source dependencies in the podspec (this issue was also brought up in #7)

looking at #7, it does allow git dependencies?? just needed to figure out the pod name

@brycehammond
Copy link
Contributor

I can update the podspec and push up the pod. @myfreeweb Currently the pod is 'CBOR', is there any objection to changing that to 'SwiftCBOR'? PR to come

@valpackett
Copy link
Owner

Yeah sounds reasonable, rename it

@brycehammond
Copy link
Contributor

@myfreeweb here is the PR: #34. Once approved can you tag it with v0.3.1

@brycehammond
Copy link
Contributor

@bgiori SwiftCBOR v0.3.0 is now on Cocoapods for you

@bgiori
Copy link
Contributor Author

bgiori commented Dec 18, 2018

@brycehammond @myfreeweb Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants