Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent implementation of Filesystem::files for FreeBSD and Linux #28

Closed
warrenfalk opened this issue Mar 7, 2018 · 1 comment
Closed

Comments

@warrenfalk
Copy link
Contributor

FreeBSD is implemented like this:

Filesystem {
    files: self.f_files as usize - self.f_ffree as usize,
    /* ... */
}

Linux is implemented like this:

Filesystem {
    files: info.f_files as usize,
    /* ... */
}

So the same field, Filesystem::files, actually has different meanings in each platform. I assume Linux is wrong here because it isn't actually very useful to have only the capacity. I plan to submit a PR for this

@valpackett
Copy link
Owner

Yeah, looking at the man pages, f_files appears to mean the same thing on both platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants