Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdf.load will fail in python3 on file-like object that return bytes #2

Closed
2 tasks
rossengeorgiev opened this issue Jul 22, 2015 · 2 comments
Closed
2 tasks

vdf.load will fail in python3 on file-like object that return bytes #2

rossengeorgiev opened this issue Jul 22, 2015 · 2 comments
Labels
bug

Comments

@rossengeorgiev
Copy link
Contributor

Ideally the behavior should change to:

  • the module should try to decode as utf-8 by default
  • there should be a keyword argument for specifying encoding
@rossengeorgiev
Copy link
Contributor Author

Probably best to solve this by wrapping string/file inputs into a BufferedReader.
That way we can seek forward/back to locate BOM, regardless of the input supporting it.

@rossengeorgiev
Copy link
Contributor Author

After some thought it would be best not to try and automatically handle bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rossengeorgiev