Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new libSDL3 has still broken alsa audio (need git commit hash) #2688

Closed
sylware opened this issue Apr 19, 2024 · 5 comments
Closed

new libSDL3 has still broken alsa audio (need git commit hash) #2688

sylware opened this issue Apr 19, 2024 · 5 comments

Comments

@sylware
Copy link

sylware commented Apr 19, 2024

The alsa fixes are not yet into upstream libSDL3.

I need the upstream libSDL3 commit hash of the currently deployed libSDL3 in order to make a build with the alsa fixes.

thx!

(meanwhile, I will try anyway to narrow down a working git commit but if you could give me the right one, would spare me some auditing work).

@sylware
Copy link
Author

sylware commented Apr 19, 2024

Oh, I forgot, the fixes are there:
libsdl-org/SDL#8577

@kisak-valve
Copy link
Member

Hello @sylware, ValveSoftware/csgo-osx-linux#3647 (comment) is equally valid here. This should be handled upstream first as maintaining the changes you want downstream doesn't make sense.

@kisak-valve kisak-valve closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
@sylware
Copy link
Author

sylware commented Apr 19, 2024

The fixes are still pending for testing and merging. It has been the case for months. Dunno what icculus is doing.

In the meantime:

The libSDL3 which was deployed with the birds patch is not compatible with upstream libSDL3 of today (symbols are being modified, removed).

I would need the upstream git commit hash your used for that libSDL3. I'll patch it with the fixes.

@sylware
Copy link
Author

sylware commented Apr 19, 2024

I found a working commit:
0d0aaa2d75265e3d9873e3a160c7ce32b311c67d

(warning: after this commit, significant symbol removals and renaming were done)

Working on publishing the fixed libSDL3 I use somewhere for download.

I did ping icculus for any news about the fixes going in. It seems very hard to get in touch with libSDL3 devs.

Because with the current code, dota2 will take exclusive access to the hardware.

@sylware
Copy link
Author

sylware commented Apr 19, 2024

libSDL3 was updated to today git in the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants