Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r70 has broken diff_match_patch_test.cpp #30

Closed
GoogleCodeExporter opened this issue Mar 13, 2016 · 2 comments
Closed

r70 has broken diff_match_patch_test.cpp #30

GoogleCodeExporter opened this issue Mar 13, 2016 · 2 comments

Comments

@GoogleCodeExporter
Copy link

I just downloaded the new diff_match_patch_20101028.zip.

I don't think this line (from r70) in diff_match_patch_test.cpp is correct:

896 +     QString resultStr =  + "\t" + sprintf(str, "%s\t%d", results.first, 
boolArray.count());


Original issue reported on code.google.com by chris...@gmail.com on 29 Oct 2010 at 1:34

@GoogleCodeExporter
Copy link
Author

You are quite right.  Looks like the version control system was used 
incorrectly.  That line should be:
896:  QString resultStr = 
QString("%1\t%2").arg(results.first).arg(boolArray.count());

Since this 'just' appears to be a broken test, and the DMP code appears to be 
correct, I'll forego an emergency push, but instead include this the next 
update which is scheduled for Friday or Monday.

Thanks for pointing this out.  My apologies.

Original comment by neil.fra...@gmail.com on 29 Oct 2010 at 4:38

  • Changed state: Started
  • Added labels: Priority-High
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

Fixed.  A new version has been committed and uploaded.

Original comment by neil.fra...@gmail.com on 29 Oct 2010 at 3:33

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant