Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Train/Test split in tutorials #101

Open
JulianKlug opened this issue Nov 14, 2023 · 1 comment
Open

[Documentation] Train/Test split in tutorials #101

JulianKlug opened this issue Nov 14, 2023 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@JulianKlug
Copy link
Contributor

Location of the documentation

Tutorial example: https://temporai.readthedocs.io/en/latest/user_guide/usage/tutorial06_treatments.html#Using-a-temporal-treatment-effects-plugin.

tempor.data.dataset module: https://temporai.readthedocs.io/en/latest/api/tempor.data.dataset.html#tempor.data.dataset.BaseDataset.split

Documentation problem

Training and inference is done on the same data in all tutorials.

Suggested fix for documentation

Encourage train / test split in tutorials.

@JulianKlug JulianKlug added the documentation Improvements or additions to documentation label Nov 14, 2023
@DrShushen
Copy link
Member

Thank you, great point in terms of encouraging sensible use of the software. This will be implemented soon.

@DrShushen DrShushen self-assigned this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants