Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing of names with nicknames #5

Closed
vaneseltine opened this issue Sep 9, 2019 · 3 comments
Closed

Improve parsing of names with nicknames #5

vaneseltine opened this issue Sep 9, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@vaneseltine
Copy link
Owner

By treating the nickname as a field separator, a first/middle or middle/last split could potentially be maintained. Currently the nickname is invisible to the subsequent processing.

@vaneseltine vaneseltine added enhancement New feature or request test__issues.py This issue is included in test/test__issues.py labels Sep 9, 2019
@vaneseltine
Copy link
Owner Author


@pytest.mark.xfail(
    raises=AssertionError,
    reason="Probably not, but add a placeholder to keep names separated",
)
def issue_5_leave_non_comma_placeholder_from_nicknames():
    name = Name("angua van (barky) uberwald")
    assert name.last == "uberwald"

@vaneseltine vaneseltine removed the test__issues.py This issue is included in test/test__issues.py label Sep 13, 2019
@vaneseltine vaneseltine added this to the 1.1 milestone Sep 16, 2019
@vaneseltine
Copy link
Owner Author

Cf. #38

@vaneseltine vaneseltine removed this from the 1.1 milestone Dec 5, 2019
@vaneseltine
Copy link
Owner Author

Single-string output and idempotence removed as design goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant