Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some graphs may have problem, I cannot put in my graph #3

Closed
ekko2 opened this issue Nov 17, 2018 · 2 comments
Closed

some graphs may have problem, I cannot put in my graph #3

ekko2 opened this issue Nov 17, 2018 · 2 comments

Comments

@ekko2
Copy link

ekko2 commented Nov 17, 2018

No description provided.

@ekko2 ekko2 closed this as completed Nov 18, 2018
@ekko2 ekko2 reopened this Nov 18, 2018
@vangj
Copy link
Owner

vangj commented Nov 19, 2018

hi, i think i've troubleshooted this problem. on page 15 of the huang paper, he says to build the optimal join tree until n-1 (n = the number of cliques) separation sets (sepsets) are added. sometimes, as in your case, the same sepset is reused to connect multiple cliques. so, following his algorithm literally will fail. i've revised the algorithm to 1) get only sepsets that have an intersection and 2) add all nodes to the join tree for form a connected graph (if it's connected, though, not tested for a disconnected join tree yet). the new version released is 0.1.5. cheers.

@vangj vangj closed this as completed Nov 19, 2018
@vangj
Copy link
Owner

vangj commented Nov 19, 2018

take a look here, your graph is placed as a unit test (though without assertions).

https://github.com/vangj/py-bbn/blob/master/tests/graph/test_jointree.py#L98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants