Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Warning: the following output files of rule get_genome_support_files were not present when the DAG was created: #682

Closed
Maarten-vd-Sande opened this issue Apr 14, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Maarten-vd-Sande
Copy link
Member

Describe the bug
Seems like genomepy automatically makes the .fa.sizes file? @siebrenf is this likely? I can test somewhere these days with the --until flag

@Maarten-vd-Sande Maarten-vd-Sande added the bug Something isn't working label Apr 14, 2021
@siebrenf
Copy link
Member

yes, it does in get_genome_support_files, which calls this script.

@Maarten-vd-Sande
Copy link
Member Author

Ah yes, sorry unclear from my part. But I think the get_genome rule already makes this file, because when the get_genome_support_files rule starts, it prints a warning that the .fa.sizes already exists.

@siebrenf
Copy link
Member

it should! I made this into a separate rule in case you already have the genome fasta or extend it.

We could leave the warning, or implement a silly fix: remove these files at the end of the get_genome script. Solution would cost <30 sec, so its not too bad.

@Maarten-vd-Sande
Copy link
Member Author

I think the cleanest way is to have it as output of both, and set a ruleorder (maybe not even necessary). Not entirely sure if that's possible though 🤔

I don't like keeping the warning, because it can put people on the wrong foot. Removing the file is also ok, but indeed a bit mehh. But I prefer this over doing nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants